HostStatus debug logging segfault fix. #4215
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
to find an entry in the hoststatus hash table.
jrushford
changed the title
vmamidi
approved these changes
Sep 7, 2018
Contributor
Author
|
@zwoop can I get this cherry-picked back to 8.0.x? |
Contributor
|
Hmmm, this slipped through the cracks big time, just ran into this while trying to debug 8.0.6 with Diagnostics, and of course, it segfaults immediately. Cherry-picked to 8.0.x |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In HostStatus::getHostStatus() a segfault can occur when debug logging is used and a lookup for a host in the host status hash table fails to find an entry.
This should be picked back to 8.0