Hash: Add hash_immediate to generic hash and FNV hashes. #4223
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SolidWallOfCode
force-pushed
the
fnv-hash-immediate
branch
from
03750f2 to
3c9fa5a
Compare
ywkaras
previously approved these changes
Sep 17, 2018
Member
Author
|
Ready to review. |
SolidWallOfCode
force-pushed
the
fnv-hash-immediate
branch
from
3c9fa5a to
1ee69b9
Compare
Member
Author
|
No one would review it, and it's now replaced by #4481. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These hashes should have
hash_immediatejust likeCryptoHash.After making fixes in the libswoc version, I ended up making more extensive changes in ATS as well, to get a cleaner interface. I also moved everything out of
HashFNV.ccbecause the code was all one liners.