Changed the Warning messages to Debug for POST redirect on buffer limits #4228
Conversation
bryancall
force-pushed
the
redirect_warn
branch
from
d6c4900 to
dede685
Compare
| if (p->buffer_start->read_avail() > HttpConfig::m_master.post_copy_size) { | ||
| Warning("http_redirect, [HttpTunnel::producer_handler] post exceeds buffer limit, buffer_avail=%" PRId64 " limit=%" PRId64 "", | ||
| p->buffer_start->read_avail(), HttpConfig::m_master.post_copy_size); | ||
| Debug("http_redirect", "[HttpTunnel::producer_handler] post exceeds buffer limit, buffer_avail=%" PRId64 " limit=%" PRId64 "", |
There was a problem hiding this comment.
If this happened, the post request will fail. Are we sure this is something we can ignore?
There was a problem hiding this comment.
@zizhong Is the post failing completely or will it just fail to do a follow redirect?
There was a problem hiding this comment.
In common cases, it fails only for the redirect. When post buffer(PR#2335) enabled, it will fail for the original too.
There was a problem hiding this comment.
That is not good for the common case, with buffering enabled. What change made it fail when post buffer is enabled? I don't believe this is how it worked before.
There was a problem hiding this comment.
that is #2335, which utilizes the same buffer logic.
|
I am going to keep the warnings since the POSTs fail to the client. It would be good to have a feature to disable buffering of POSTs for follow redirect. |
4 participants
I was seeing about 20 of these warning per second in production on 8.0.0 RC0