Skip to content

Corrects path to test file in docs #4234

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
SolidWallOfCode merged 1 commit into from
Sep 12, 2018
Merged

Corrects path to test file in docs #4234

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions doc/developer-guide/internal-libraries/intrusive-list.en.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -190,13 +190,13 @@ In some cases the elements of the list are subclasses and the links are declared
and are therefore of the super class type. For instance, in the unit test a class :code:`Thing` is
defined for testing.

.. literalinclude:: ../../../lib/ts/unit-tests/test_IntrusiveDList.cc
.. literalinclude:: ../../../src/tscore/unit_tests/test_IntrusiveDList.cc
:lines: 159

Later on, to validate use on a subclass, :code:`PrivateThing` is defined as a subclass of
:code:`Thing`.

.. literalinclude:: ../../../lib/ts/unit-tests/test_IntrusiveDList.cc
.. literalinclude:: ../../../src/tscore/unit_tests/test_IntrusiveDList.cc
:lines: 181

However, the link members :code:`_next` and :code:`_prev` are of type :code:`Thing*` but the
Expand All @@ -205,7 +205,7 @@ descriptor for a list of :code:`PrivateThing` must have link accessors that retu
:code:`ts::ptr_ref_cast<X, T>` that converts a member of type :code:`T*` to a reference to a pointer
to :code:`X`, e.g. :code:`X*&`. This is used in the setup for testing :code:`PrivateThing`.

.. literalinclude:: ../../../lib/ts/unit-tests/test_IntrusiveDList.cc
.. literalinclude:: ../../../src/tscore/unit_tests/test_IntrusiveDList.cc
:lines: 190-199

While this can be done directly with :code:`reinterpret_cast<>`, use of :code:`ts::ptr_cast` avoids
Expand Down