Set log code when closing half open connections. #4267
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since we now disallow half open connections for HTTP1/TLS we need to set the log code when we close these connections so that the 'crc' code is ERR_CLIENT_ABORT rather than ERR_UNKNOWN.
bryancall
approved these changes
Sep 20, 2018
Contributor
Author
Contributor
|
@pbchou Sure. Can you make a PR against the 7.1.x branch as well please? |
Contributor
Author
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since we now disallow half open connections for HTTP1/TLS we need
to set the log code when we close these connections so that
the 'crc' code is ERR_CLIENT_ABORT rather than ERR_UNKNOWN.