Skip to content

Test: Convert test_X509HostnameValidator.cc to Catch #4268

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
bryancall merged 1 commit into from
Sep 19, 2018
Merged

Test: Convert test_X509HostnameValidator.cc to Catch #4268

bryancall merged 1 commit into from
Sep 19, 2018

Conversation

@nqyy
Copy link
Contributor

@nqyy nqyy commented Sep 19, 2018 •
edited
Loading

test_X509HostnameValidator.cc split from #4254

Note: Since test_X509HostnameValidator has its own main function, #define CATCH_CONFIG_RUNNER is used. So it is separate from other catch tests from test_tscore.

@SolidWallOfCode
Copy link
Member

SolidWallOfCode commented Sep 19, 2018 •
edited
Loading

I think a more important reason is this needs the openSSL library and the other tests do not.

@SolidWallOfCode SolidWallOfCode added this to the 9.0.0 milestone Sep 19, 2018
@SolidWallOfCode SolidWallOfCode self-assigned this Sep 19, 2018
bryancall
bryancall approved these changes Sep 19, 2018
View reviewed changes
Copy link
Contributor

@bryancall bryancall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@bryancall bryancall merged commit aa3806d into apache:master Sep 19, 2018
@bryancall bryancall assigned nqyy and unassigned SolidWallOfCode Sep 19, 2018
@nqyy nqyy deleted the test1 branch September 20, 2018 15:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bryancall bryancall bryancall approved these changes

+1 more reviewer

@SolidWallOfCode SolidWallOfCode SolidWallOfCode approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@nqyy nqyy

Labels

Cleanup Tests

Projects

None yet

Milestone

9.0.0

Development

Successfully merging this pull request may close these issues.

3 participants

@nqyy @SolidWallOfCode @bryancall