Skip to content

Test: Fix issues with new Catch unit tests #4287

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
bryancall merged 1 commit into from
Sep 21, 2018
Merged

Test: Fix issues with new Catch unit tests #4287

bryancall merged 1 commit into from
Sep 21, 2018

Conversation

@nqyy
Copy link
Contributor

@nqyy nqyy commented Sep 21, 2018

After the conversion, some for loops generate too many assertions.
A printf is also gotten rid of.

@bryancall
Copy link
Contributor

bryancall commented Sep 21, 2018 •
edited
Loading

Why are they asserting? I don't understand the issue.

@bryancall bryancall added this to the 9.0.0 milestone Sep 21, 2018
@nqyy
Copy link
Contributor Author

nqyy commented Sep 21, 2018 •
edited
Loading

Previously, it was some ink_assert or box.check(). After changing to REQUIRE(), there are millions of assertions in those for loops.

@bryancall bryancall merged commit 8579dca into apache:master Sep 21, 2018
@bryancall bryancall modified the milestones: 9.0.0, 8.0.1 Oct 10, 2018
@nqyy nqyy deleted the testfix branch November 2, 2018 22:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bryancall bryancall bryancall approved these changes

Assignees

@nqyy nqyy

Labels

Tests

Projects

None yet

Milestone

8.0.1

Development

Successfully merging this pull request may close these issues.

2 participants

@nqyy @bryancall