Expand the post chunked tests. #4300
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maskit
reviewed
Sep 24, 2018
tests/gold_tests/h2/http2.test.py
Outdated
| {"headers": "HTTP/1.1 200 OK\r\nServer: microserver\r\nConnection: close\r\nContent-Length: 10\r\n\r\n", "timestamp": "1469733493.993", "body": "0123456789"}) | ||
|
|
||
| # Make a post body that will be split across at least two frames | ||
| big_post_body = "023456789" * 131070 |
Member
Author
There was a problem hiding this comment.
Yes, meant to have a 1 there too. Will add
shinrich
force-pushed
the
augment_post_chunked_tests
branch
from
78b68b5 to
c8acee4
Compare
Member
Author
|
Pushed new version to fix typo in big post body. |
maskit
approved these changes
Sep 25, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding another test with a chunked post body that will cross multiple data frames.
In the course of writing this test, I realized that the micro server does not check the post body to verify that the post body matches the request definition. Need to add another lookup key option, but will do that in a separate PR.
I eyeballed the debug messages to ensure that the post data chunks were overlapping appropriately.