remap.config .include files trigger reloads #4308
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previous behavior required operator to touch toplevel remap.config to trigger reload if the operator modified an included remap file.
zwoop
reviewed
Oct 10, 2018
Contributor
zwoop
left a comment
zwoop
left a comment
There was a problem hiding this comment.
Looks good to me, but would like some non- to review.
Contributor
|
I think this is an 8.0.x or 8.1.x candidate (i'm ok either way, seeing that not doing this can be considered a bug, I think 8.0.x would be fine) |
bryancall
approved these changes
Oct 10, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previous behavior required operator to touch toplevel remap.config
to trigger reload if the operator modified an included remap file.