YAML: LibSWOC IntrusiveDList update. #4424
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SolidWallOfCode
force-pushed
the
libswoc-intrusivedlist
branch
from
836b120 to
8a9badc
Compare
randall
reviewed
Oct 17, 2018
| ts::bwprint(name, "Item {}", i); | ||
| priv_list.append(new PrivateThing(name)); | ||
| char buff[64]; | ||
| // ts::bwprint(name, "Item {}", i); |
Contributor
There was a problem hiding this comment.
Remove commented out code?
Member
Author
There was a problem hiding this comment.
No, unfortunately. Because I'm bringing this back in pieces, rather than one massive PR, I need to break some internal dependencies. That's what the commented code is. I plan to restore it when I bring in the pieces on which it depends.
Contributor
There was a problem hiding this comment.
ok. that makes more sense.
Contributor
|
Need a rebase for this. |
SolidWallOfCode
force-pushed
the
libswoc-intrusivedlist
branch
from
8a9badc to
abc9c9c
Compare
zwoop
added
the
OnDocs
maskit
reviewed
Oct 22, 2018
| } | ||
|
|
||
| TEST_CASE("IntrusiveDList Example", "[libts][IntrusiveDList]") | ||
| TEST_CASE("IntrusiveDList Example", "[libswoc][IntrusiveDList]") |
Member
Author
There was a problem hiding this comment.
No, I missed that one. Sigh.
Move to 'ts' namespace, make plugin accessible, add some additional link support.
SolidWallOfCode
force-pushed
the
libswoc-intrusivedlist
branch
from
abc9c9c to
f11eab6
Compare
randall
approved these changes
Oct 22, 2018
zwoop
removed
OnDocs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the start of backporting the necessary infrastructure updates to ATS to support Canned-YAML. The current full change list is here.
Nothing major, but a number of minor fixes. This also moves
IntrusiveDListto thetsnamespace.