TextView: Add TransformView for doing in place transforms on string views. #4480
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SolidWallOfCode
force-pushed
the
yaml-libswoc-transform-view
branch
from
9c92dad to
d1a2530
Compare
Contributor
|
I don't know, do we really need this? Can we stay within C++17 for at least a few years? |
Member
Author
|
I'm using it for the hash functor refactoring. It has other uses as well. But I realize that it's wrong to restructure things already being done in the code base in to a more general facility that is forward looking. Better to keep local ad hoc implementations that don't correspond to current practices. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is inline with efforts in C++20 to do "Ranges" for this same purpose. The initial point of this is better support for hashing, in particular for caseless hashing. Rather that it being a special purpose mechanism, this creates a more general mechanism that can be used for the same purpose. That makes adding it to various hash functors easier, and makes it available for other uses.