Add SNI-based cert selection test. #4658
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shinrich
force-pushed
the
add_cert_selection_test
branch
from
1d6ad83 to
dca26e8
Compare
shinrich
force-pushed
the
add_cert_selection_test
branch
from
dca26e8 to
f4bf73c
Compare
| # override for foo.com policy=enforced properties=all | ||
| ts.Disk.records_config.update({ | ||
| 'proxy.config.diags.debug.enabled': 0, | ||
| 'proxy.config.diags.debug.tags': 'http|ssl|dns|hostdb', |
Member
There was a problem hiding this comment.
Why set these, if debug is not enabled?
Member
Author
There was a problem hiding this comment.
I was tweaking them during debugging the feature.
SolidWallOfCode
approved these changes
Dec 6, 2018
Contributor
|
Cherry picked to 8.1.0 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As openssl-1.1.1a comes out, thought we should have a test that checks for regressions in SNI-based certificate selection.