Skip to content

regex_revalidate: don't start a new self scheduling config handler on every config reload #4713

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
shinrich merged 1 commit into from
Jan 7, 2019
Merged

regex_revalidate: don't start a new self scheduling config handler on every config reload #4713

shinrich merged 1 commit into from
Jan 7, 2019

Conversation

@traeak
Copy link
Contributor

@traeak traeak commented Dec 17, 2018 •
edited
Loading

Also replace core includes with plugin api includes.
I would like to have this back ported to both 8.x and 7.x.

@traeak traeak force-pushed the regex_revalidate_contleak branch from 509ce99 to e662cec Compare December 17, 2018 20:50
@traeak traeak changed the title Don't start a new self scheduling config handler on every config reload regex_revalidate: Don't start a new self scheduling config handler on every config reload Dec 17, 2018
@traeak traeak changed the title regex_revalidate: Don't start a new self scheduling config handler on every config reload regex_revalidate: don't start a new self scheduling config handler on every config reload Dec 17, 2018
shinrich
shinrich approved these changes Dec 18, 2018
View reviewed changes
Copy link
Member

@shinrich shinrich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems reasonable

@randall randall added this to the 9.0.0 milestone Dec 27, 2018
@shinrich shinrich merged commit ce6caf9 into apache:master Jan 7, 2019
@ezelkow1 ezelkow1 modified the milestones: 9.0.0, 8.0.3, 8.1.0 Mar 8, 2019
@bryancall bryancall modified the milestones: 8.0.3, 8.1.0 Mar 27, 2019
@bryancall
Copy link
Contributor

bryancall commented Mar 27, 2019

Cherry picked to 8.1.0

@zwoop zwoop modified the milestones: 8.1.0, 8.1.0-nogo Mar 18, 2020
@traeak traeak deleted the regex_revalidate_contleak branch January 13, 2023 18:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@shinrich shinrich shinrich approved these changes

Assignees

@traeak traeak

Labels

Plugins

Projects

None yet

Milestone

8.1.0-nogo

Development

Successfully merging this pull request may close these issues.

6 participants

@traeak @bryancall @shinrich @zwoop @randall @ezelkow1