Revert "Two more places to check whether attempting half_closed connecton logic is feasible" #4716
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ction logic is feasible." This reverts commit 653927f. Erroneous fix caused KEEPALIVE to fail on HTTP/1.1 over HTTPS
Contributor
|
Cherry-picked to 8.0.x |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts commit 653927f.
Erroneous fix caused KEEPALIVE to fail on HTTP/1.1 over HTTPS
Found by @zwoop, @mlibbey, @masaori335 and @maskit to have bad interactions with PR #4213. In a separate PR I will add tests to catch regressions in client-side keep alive.