Skip to content

Assert when sm callback to wrong thread #4860

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
scw00 merged 1 commit into from
Feb 12, 2019
Merged

Assert when sm callback to wrong thread #4860

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion src/traffic_server/InkAPI.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5920,13 +5920,14 @@ TSHttpTxnReenable(TSHttpTxn txnp, TSEvent event)
// If this function is being executed on a thread created by the API
// which is DEDICATED, the continuation needs to be called back on a
// REGULAR thread.
if (eth == nullptr || eth->tt != REGULAR) {
if (eth == nullptr || eth->tt != REGULAR || !eth->is_event_type(ET_NET)) {
eventProcessor.schedule_imm(new TSHttpSMCallback(sm, event), ET_NET);
} else {
MUTEX_TRY_LOCK(trylock, sm->mutex, eth);
if (!trylock.is_locked()) {
eventProcessor.schedule_imm(new TSHttpSMCallback(sm, event), ET_NET);
} else {
ink_assert(eth->is_event_type(ET_NET));
sm->state_api_callback((int)event, nullptr);
}
}
Expand Down