Add history to HTTP/2 #4944
Merged
Add history to HTTP/2 #4944
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SolidWallOfCode
previously approved these changes
Feb 7, 2019
Member
SolidWallOfCode
left a comment
SolidWallOfCode
left a comment
There was a problem hiding this comment.
It's unfortunate REMEMBER needs to be a #define, I need to think of how to get around that.
masaori335
force-pushed
the
h2-history
branch
from
1fe4b6c to
915bc60
Compare
Contributor
Author
|
clang-analyzer issues are fixed. |
shinrich
approved these changes
Feb 8, 2019
zwoop
approved these changes
Feb 11, 2019
Contributor
|
Cherry picked to 8.1.0. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
For tracking #4504, I added history feature to HTTP/2 component which is used in HttpSM. It was quite useful for debugging. This is bit generalized from what we deployed for #4504.
This PR includes
_historymember to Http2ClientSession and Http2Stream_history, because they're sharing mutex.Memory footprint
History is ring buffer and the size is 2088 bytes. (HISTORY_DEFAULT_SIZE * sizeof(HistoryEntry) + sizeof(unsigned int) = 65 * 32 + 8 ) It looks acceptable.