Skip to content

Implement nbf claim in Uri Signing Plugin #4988

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ezelkow1 merged 1 commit into from
Feb 25, 2019
Merged

Implement nbf claim in Uri Signing Plugin #4988

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 2 additions & 8 deletions plugins/experimental/uri_signing/jwt.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -97,12 +97,6 @@ unsupported_string_claim(const char *str)
return !str;
}

bool
unsupported_date_claim(double t)
{
return isnan(t);
}

bool
jwt_validate(struct jwt *jwt)
{
Expand All @@ -126,8 +120,8 @@ jwt_validate(struct jwt *jwt)
return false;
}

if (!unsupported_date_claim(jwt->nbf)) {
PluginDebug("Initial JWT Failure: nbf unsupported");
if (now() < jwt->nbf) {
PluginDebug("Initial JWT Failure: nbf claim violated");
return false;
}

Expand Down