Ran clang-tidy with modernize-use-default-member-init #5186
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
masaori335
force-pushed
the
modernize-use-default-member-init
branch
2 times, most recently
from
a3bd11c to
1fb15e0
Compare
1. Remove unmatched #endif and set `_location` nullptr. - iocore/eventsystem/I_IOBuffer.h - iocore/eventsystem/P_IOBuffer.h 2. Include "ts/apidefs.h" - include/tscpp/api/Stat.h 3. Rollback changes made with -fix-error option (clang-diagnostic-implicit-function-declaration) - plugins/lua/ts_lua_client_request.c - plugins/lua/ts_lua_client_response.c - plugins/lua/ts_lua_server_response.c - plugins/experimental/remap_stats/remap_stats.c
masaori335
force-pushed
the
modernize-use-default-member-init
branch
from
1fb15e0 to
e28ec4b
Compare
Contributor
Author
|
Rebased. This is ready for review. |
bryancall
approved these changes
Mar 25, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The modernize-use-default-member-init makes constructors modern and consistent.
I enabled UseAssignment option, because many current code initialise members with an assignment.
Below files are changed by hand.
Remove unmatched #endif and set
_locationnullptr.Include "ts/apidefs.h"
Rollback changes made with -fix-error option (clang-diagnostic-implicit-function-declaration) -> Suppress false positive of clang-tidy on macOS #5193
This includes #5182 changes. I'll rebase this when it is merged.