Skip to content

Slice Plugin: add options for disabling or pacing detailed block stitch error logging. #5301

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
ezelkow1 merged 1 commit into from
Apr 26, 2019
Merged

Slice Plugin: add options for disabling or pacing detailed block stitch error logging. #5301

ezelkow1 merged 1 commit into from
Apr 26, 2019

Conversation

@traeak
Copy link
Contributor

@traeak traeak commented Apr 22, 2019 •
edited
Loading

Switching configuration over to using getopt_long. Still retains compatibility with blockbytes:[bytes] option.

Added the errorlog features in order to possibly avoid swamping diags.log with block stitching errors in case origins decide to (unwisely) modify assets in place.

Options:

--blockbytes=[bytes] (or -b [bytes]) (or blockbytes:[bytes] for backwards compat)
--test-blockbytes=[bytes] (or -t [bytes])
--pace-errorlog=[seconds] (or -p [seconds])
--disable-errorlog (or -d)

@traeak traeak changed the title switch over to using getopt, add --disable-errorlog option for spam case Change errorlog message to slice_error debug tag, change configuration to use getopt_long Apr 22, 2019
@traeak traeak changed the title Change errorlog message to slice_error debug tag, change configuration to use getopt_long Add plugin options for disabling or pacing block stitching error logging. Apr 24, 2019
@traeak traeak changed the title Add plugin options for disabling or pacing block stitching error logging. Slice Plugin: add options for disabling or pacing detailed block stitching error logging. Apr 24, 2019
@traeak traeak changed the title Slice Plugin: add options for disabling or pacing detailed block stitching error logging. Slice Plugin: add options for disabling or pacing detailed block stitch error logging. Apr 24, 2019
@traeak traeak marked this pull request as ready for review April 24, 2019 17:57
@randall
Copy link
Contributor

randall commented Apr 25, 2019

[approve ci autest]

@randall randall added this to the 9.0.0 milestone Apr 25, 2019
@ezelkow1 ezelkow1 merged commit b42fb60 into apache:master Apr 26, 2019
@traeak traeak mentioned this pull request Mar 30, 2020
Merged
@zwoop zwoop modified the milestones: 9.0.0, 8.1.0 Apr 6, 2020
@traeak traeak deleted the slice_config branch January 13, 2023 18:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ezelkow1 ezelkow1 ezelkow1 approved these changes

Assignees

@traeak traeak

Labels

Plugins

Projects

None yet

Milestone

8.1.0

Development

Successfully merging this pull request may close these issues.

4 participants

@traeak @randall @ezelkow1 @zwoop