Skip to content

Lost fragments table when update object in Cache #5342

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
taaotao007 wants to merge 3 commits into from
Closed

Lost fragments table when update object in Cache #5342

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
5c20b6f
dataerror-pr
Apr 24, 2019
f02f98d
fix build error
May 6, 2019
0b47563
fix building error
May 7, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 8 additions & 1 deletion iocore/cache/CacheWrite.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -106,7 +106,14 @@ CacheVC::updateVector(int /* event ATS_UNUSED */, Event * /* e ATS_UNUSED */)
data should remain valid.
*/
if (alternate_index >= 0) {
alternate.copy_frag_offsets_from(write_vector->get(alternate_index));
/*if length changed, fragment offset also need to change, if not cause range request error*/
if (total_len != uint64_t(write_vector->get(alternate_index)->object_size_get())) {
Debug("cache_update", "update length changed, new length:%lu, old length:%ld", total_len,
write_vector->get(alternate_index)->object_size_get());
} else {
/*do not copy everytimes, if data changed, this copy makes range request error*/
alternate.copy_frag_offsets_from(write_vector->get(alternate_index));
}
}
alternate_index = write_vector->insert(&alternate, alternate_index);
}
Expand Down