This fixes parsing where the [ ] section gets merged into values #5423
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
This fixes a regression Comcast found on the 8.1.x branch. If we're moving along with 8.1.x as-is, this (or something like this) needs to be back ported there too. |
zwoop
force-pushed
the
HeaderRewriteParsing
branch
from
bb3599d to
bb08592
Compare
For example:
cond %{SEND_RESPONSE_HDR_HOOK}
set-header X-First "First"
set-header X-Last "Last" [L]
would set the header X-Last: Last [L].
In addition, it also fixes a typo (I think?) in an unrelated test,
however, it's unclear as to why it's not failing that test.
CHECK_EQ(p.get_tokens()[1], "%{METHOD}c”);
zwoop
force-pushed
the
HeaderRewriteParsing
branch
from
bb08592 to
3b0bfcd
Compare
randall
approved these changes
May 6, 2019
jrushford
reviewed
May 7, 2019
Contributor
jrushford
left a comment
jrushford
left a comment
There was a problem hiding this comment.
Looks good to me. I tested the header_rewrite plugin with set-header and the issue is resolved. The [L] is no-longer sent on the wire with the header and data.
whutwhu
pushed a commit
to whutwhu/trafficserver
that referenced
this pull request
May 23, 2020
… char (apache#6340) * Add header rewrite test to make sure we are not injecting end of rule characters in to an actual header This is a regression check for the issue fixed in apache#5423
brbzull0
pushed a commit
to brbzull0/trafficserver
that referenced
this pull request
Sep 2, 2020
… char (apache#6340) * Add header rewrite test to make sure we are not injecting end of rule characters in to an actual header This is a regression check for the issue fixed in apache#5423
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For example:
would set the header X-Last: Last [L]