Skip to content

gcc9 - fix class Connection. #5427

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
SolidWallOfCode merged 1 commit into from
May 6, 2019
Merged

gcc9 - fix class Connection. #5427

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 10 additions & 5 deletions iocore/net/P_Connection.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -132,6 +132,7 @@ struct Connection {

virtual ~Connection();
Connection();
Connection(Connection const &that) = delete;

/// Default options.
static NetVCOptions const DEFAULT_OPTIONS;
Expand All @@ -141,12 +142,16 @@ struct Connection {
*/
void move(Connection &);

private:
// Don't want copy constructors to avoid having the deconstructor on
// temporarily copies close the file descriptor too soon. Use move instead
Connection(Connection const &);

protected:
/** Assignment operator.
*
* @param that Source object.
* @return @a this
*
* This is protected because it is not safe in the general case, but is valid for
* certain subclasses. Those provide a public assignemnt that depends on this method.
*/
Connection &operator=(Connection const &that) = default;
void _cleanup();
};

Expand Down