Skip to content

Fixed clang-analyzer issue calling schedule_imm with the continuation possibly being a nullptr #5460

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
bryancall merged 1 commit into from
May 15, 2019
Merged

Fixed clang-analyzer issue calling schedule_imm with the continuation possibly being a nullptr #5460

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions proxy/http2/Http2Stream.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -91,9 +91,9 @@ Http2Stream::main_event_handler(int event, void *edata)
case VC_EVENT_WRITE_COMPLETE:
inactive_timeout_at = Thread::get_hrtime() + inactive_timeout;
if (e->cookie == &write_vio) {
if (write_vio.mutex) {
if (write_vio.mutex && write_vio.cont && this->current_reader) {
MUTEX_TRY_LOCK(lock, write_vio.mutex, this_ethread());
if (lock.is_locked() && write_vio.cont && this->current_reader) {
if (lock.is_locked()) {
write_vio.cont->handleEvent(event, &write_vio);
} else {
this_ethread()->schedule_imm(write_vio.cont, event, &write_vio);
Expand All @@ -107,9 +107,9 @@ Http2Stream::main_event_handler(int event, void *edata)
case VC_EVENT_READ_READY:
inactive_timeout_at = Thread::get_hrtime() + inactive_timeout;
if (e->cookie == &read_vio) {
if (read_vio.mutex) {
if (read_vio.mutex && read_vio.cont && this->current_reader) {
MUTEX_TRY_LOCK(lock, read_vio.mutex, this_ethread());
if (lock.is_locked() && read_vio.cont && this->current_reader) {
if (lock.is_locked()) {
read_vio.cont->handleEvent(event, &read_vio);
} else {
this_ethread()->schedule_imm(read_vio.cont, event, &read_vio);
Expand Down