Skip to content

Conversation

@maskit
Copy link
Member

@maskit maskit commented May 10, 2019

This is a part of preparation to merge quit-latest branch. Because some of header compression logic are common between HPACK and QPACK, I separated out the logic to hdrs directory.

The code come from quic-latest branch, and it has been working for long time on a QUIC test sever (both H2 and H3 are enabled).

Only change I made is adding n parameter to encode_string and decode_string. On HPACK n is always 7 but QPACK passes other values.

Current:

int64_t encode_string(uint8_t *buf_start, const uint8_t *buf_end, const char *value, size_t value_len);		
int64_t decode_string(Arena &arena, char **str, uint32_t &str_length, const uint8_t *buf_start, const uint8_t *buf_end);

New:

int64_t xpack_encode_string(uint8_t *buf_start, const uint8_t *buf_end, const char *value, uint64_t value_len, uint8_t n = 7);
int64_t xpack_decode_string(Arena &arena, char **str, uint64_t &str_length, const uint8_t *buf_start, const uint8_t *buf_end, uint8_t n = 7);

@maskit maskit added the HTTP/2 label May 10, 2019
@maskit maskit added this to the 9.0.0 milestone May 10, 2019
@maskit maskit self-assigned this May 10, 2019
@maskit
Copy link
Member Author

maskit commented May 13, 2019

This is for H2 and H3, but I want an approval from somebody not working on QUIC because this change comes from QUIC branch.

@maskit
Copy link
Member Author

maskit commented Jul 3, 2019

[approve ci autest]

@maskit maskit merged commit eb87569 into apache:master Jul 10, 2019
@zwoop zwoop modified the milestones: 9.0.0, 8.1.0 Mar 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants