Do not change stream state from HALF_CLOSED_REMOTE with CONTINUATION frame #5585
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
masaori335
force-pushed
the
h2-huge-resp-hdr
branch
from
04cb6af to
0931d8e
Compare
masaori335
force-pushed
the
h2-huge-resp-hdr
branch
from
0931d8e to
d442d6e
Compare
Contributor
Author
|
[approve ci autest] |
Member
|
The http2 autest core dumped. |
Contributor
Author
Contributor
Author
|
This is ready for review, the autest crash is fixed. |
Member
|
Looks good to me. Did you run h2spec? |
maskit
approved these changes
Jun 10, 2019
Contributor
Author
|
I got same result to h2spec against to latest master. Some tests for section 6 are failed and should be fixed, but these are not related to this change.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #5584. This should be backported to 7.1.x and 8.0.x.
Marking draft PR while working with autest.