Skip to content

Conversation

@maskit
Copy link
Member

@maskit maskit commented Jun 25, 2019

Add a mechanism to use std::unique_ptr with ats_malloc.

This is required by QUIC code.

@maskit maskit added the Core label Jun 25, 2019
@maskit maskit added this to the 9.0.0 milestone Jun 25, 2019
@maskit maskit self-assigned this Jun 25, 2019
@maskit maskit mentioned this pull request Jun 25, 2019
12 tasks
@randall
Copy link
Contributor

randall commented Jun 25, 2019

[approve ci autest]

Copy link
Member

@zizhong zizhong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@SolidWallOfCode
Copy link
Member

Any reason to not use std::vector<uint8_t>?

@maskit
Copy link
Member Author

maskit commented Jun 28, 2019

@SolidWallOfCode I don't see any reasons to use std::vector<uint8_t>. What I want to do is managing buffer allocated by ats_malloc with a smart pointer mechanism. Are you suggesting we don't need to use ats_malloc?

@maskit
Copy link
Member Author

maskit commented Jun 28, 2019

Talked on Slack, and my understanding is:
We could/should use std::vector<uint8_t> or std::string instead of ats_malloc in general. Because these two should provide what we need, we might be able to deprecate ats_malloc in the future.

For now, I'd like to stick with the ordinary way (ats_malloc). Replacing internal implementation later shouldn't be difficult.

Merging this for coming 9.0 branching.

@maskit maskit merged commit d2e6a9e into apache:master Jun 28, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants