-
Notifications
You must be signed in to change notification settings - Fork 848
Add effective url options to slice plugin. #5727
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
51bba56 to
0dd7f30
Compare
e040c09 to
f60983d
Compare
Contributor
Author
|
Dealing with head requests for the effective url path...solve with virtual forward proxy rule... |
Contributor
|
[approve ci] |
bdf32d1 to
55869b0
Compare
jrushford
reviewed
Nov 6, 2019
jrushford
approved these changes
Nov 6, 2019
Contributor
jrushford
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good
Contributor
|
[approve ci ubuntu] |
1 similar comment
Contributor
|
[approve ci ubuntu] |
Contributor
|
Do you want this for 9.0.x ? |
Contributor
|
Yes please.
From: Leif Hedstrom <notifications@github.com>
Reply-To: apache/trafficserver <reply@reply.github.com>
Date: Wednesday, November 13, 2019 at 8:53 PM
To: apache/trafficserver <trafficserver@noreply.github.com>
Cc: John Rushford <John_Rushford@cable.comcast.com>, State change <state_change@noreply.github.com>
Subject: Re: [apache/trafficserver] Add effective url options to slice plugin. (#5727)
Do you want this for 9.0.x ?
—
You are receiving this because you modified the open/close state.
Reply to this email directly, view it on GitHub<#5727?email_source=notifications&email_token=ABCXE3R4NGGTRXDBSUQVMBTQTTDSVA5CNFSM4IEARSD2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEEAP2PQ#issuecomment-553712958>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/ABCXE3SZ772AR6RPYHVKPGLQTTDSVANCNFSM4IEARSDQ>.
|
Contributor
|
Cherry-picked to v9.0.x branch. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Initial slice plugin used pristine url to virtually call back into the same rule. This allows using a single remap line, but it has a disadvantage of rerunning all plugin rules for each slice transaction in addition to the incoming request transaction. Also it makes log analysis more difficult, the only difference being that the callback comes in on port '0'. http and https get a bit confusing as well with using the pristine url as the loopback is connected with the https url if the incoming rule is https.
This changes the default remap behaviour of the slice plugin to use a virtual remap parent point, allowing separate remap lines.
the way to set up the slice plugin with effective url: (option --remap-host= or -r )
Previous configuration is still default behavior (uri_signs for incoming AND each sliced up block):