Skip to content

Address possible use after free issue in HttpVCTable::remove_entry #5809

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
zwoop merged 1 commit into from
Oct 2, 2019
Merged

Address possible use after free issue in HttpVCTable::remove_entry #5809

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 4 additions & 20 deletions proxy/http/HttpSM.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -194,26 +194,10 @@ HttpVCTable::remove_entry(HttpVCTableEntry *e)
free_MIOBuffer(e->write_buffer);
e->write_buffer = nullptr;
}
if (e->read_vio != nullptr && e->read_vio->cont == sm) {
// Cleanup dangling i/o
if (e == sm->get_ua_entry() && sm->get_ua_txn() != nullptr) {
e->read_vio = sm->get_ua_txn()->do_io_read(nullptr, 0, nullptr);
} else if (e == sm->get_server_entry() && sm->get_server_session()) {
e->read_vio = sm->get_server_session()->do_io_read(nullptr, 0, nullptr);
} else {
ink_release_assert(false);
}
}
if (e->write_vio != nullptr && e->write_vio->cont == sm) {
// Cleanup dangling i/o
if (e == sm->get_ua_entry() && sm->get_ua_txn()) {
e->write_vio = sm->get_ua_txn()->do_io_write(nullptr, 0, nullptr);
} else if (e == sm->get_server_entry() && sm->get_server_session()) {
e->write_vio = sm->get_server_session()->do_io_write(nullptr, 0, nullptr);
} else {
ink_release_assert(false);
}
}
Comment on lines -197 to -216
Copy link
Contributor

@zwoop zwoop Oct 1, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is cool, you can do multi-line comments now :).

// Cannot reach in to checkout the netvc
// for remaining I/O operations because the netvc
// may have been deleted at this point and the pointer
// could be stale.
e->read_vio = nullptr;
e->write_vio = nullptr;
e->vc_handler = nullptr;
Expand Down