Avoid AWS auth v4 path/query param double encoding #5823
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AWS signature validation differs from the spec published here (or spec not detailed enough): http://docs.aws.amazon.com/AmazonS3/latest/API/sig-v4-header-based-auth.html ("Task 1: Create a Canonical Request”) During signature calculation (CanonicalURI and CanonicalQueryString inside the CanonicalRequest) AWS avoids URI encoding of already encoded path or query parameters which is nowhere mentioned in the specification but it is likely done according to rfc3986#section-2.4 which says "implementations must not percent-encode or decode the same string more than once ..." We already had a fix for query parementer values. Added missing checks to be consistent with AWS behavior while still waiting for response/confirmation from AWS.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
AWS signature validation differs from the spec published here (or spec
not detailed enough): "Task 1: Create a Canonical Request”
During signature calculation (
CanonicalURIandCanonicalQueryStringinside the
CanonicalRequest) AWS avoids URI encoding of alreadyencoded path or query parameters which is nowhere mentioned in the
specification but it is likely done according to rfc3986#section-2.4
which says "implementations must not percent-encode or decode the
same string more than once ..."
We already had a fix for query parementer values. Added missing
checks to be consistent with AWS behavior while still waiting for
response/confirmation from AWS.