-
Notifications
You must be signed in to change notification settings - Fork 849
cachekey: added --canonical-prefix parameter #5865
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
cachekey: added --canonical-prefix parameter #5865
Conversation
|
This patch fixes a problem found by @knutsel while using I would like to have this PR back ported to 9.x as a "bug fix" for this broken use-case which would allow |
|
An offline chat with @ezelkow1 about his experiments with this new feature made me realize that an arbitrary combining of all prefix related parameters could also yield a valid host name in the final resulting cache key, depending on the static value provided ( |
|
[approve ci autest] |
ezelkow1
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, tested here with various scenarios. After the last fix push it seems to work as advertised
In certain use-cases when calculating the prefix (the initial value of the new cache key) we need to have the scheme, host and port in their original form from the request URI, i.e. when hosting.config is used the cache key is expected to contain a valid URI authority element used for volume selection. More details about the new parameter and its functionality can be found in doc/admin-guide/plugins/cachekey.en.rst
|
Cherry-picked to v9.0.x branch. |
|
Cherry-picked to 8.1.x |
In certain use-cases when calculating the prefix (the initial value
of the new cache key) we need to have the scheme, host and port in
their original form from the request URI, i.e. when hosting.config
is used the cache key is expected to contain a valid URI authority
element used for volume selection.
More details about the new parameter and its functionality can be
found in doc/admin-guide/plugins/cachekey.en.rst