Skip to content

Add protection against use after free due to Http2ConnectionState::destroy() being called more than once per session. #5878

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sudheerv merged 2 commits into from
Jan 6, 2020
Merged

Add protection against use after free due to Http2ConnectionState::destroy() being called more than once per session. #5878

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
842c5ce
Add in_destroy to Http2ConnectionState to prevent
sudheerv Aug 27, 2019
8884fa8
Make sure shutdown_cont_event isn't holding any garbage references.
sudheerv Sep 27, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions proxy/http2/Http2ConnectionState.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -140,8 +140,14 @@ class Http2ConnectionState : public Continuation
void
destroy()
{
if (in_destroy) {
schedule_zombie_event();
return;
}
in_destroy = true;
if (shutdown_cont_event) {
shutdown_cont_event->cancel();
shutdown_cont_event = nullptr;
}
cleanup_streams();

Expand Down Expand Up @@ -374,6 +380,7 @@ class Http2ConnectionState : public Continuation
Http2StreamId continued_stream_id = 0;
bool _scheduled = false;
bool fini_received = false;
bool in_destroy = false;
int recursion = 0;
Http2ShutdownState shutdown_state = HTTP2_SHUTDOWN_NONE;
Http2ErrorCode shutdown_reason = Http2ErrorCode::HTTP2_ERROR_MAX;
Expand Down