Skip to content

Conversation

@bryancall
Copy link
Contributor

@bryancall bryancall commented Aug 27, 2019

When doing to QUIC builds for Github-autest I saw this issue:

The second argument should be a non const:

#  define EVP_PKEY_assign_RSA(pkey,rsa) EVP_PKEY_assign((pkey),EVP_PKEY_RSA,\
                                        (char *)(rsa))

Error from CI:

In file included from experimental/magick/magick.cc:39:0:
experimental/magick/magick.cc: In member function 'bool magick::EVPKey::assign(const char*) const':
experimental/magick/magick.cc:190:45: error: invalid conversion from 'const void*' to 'void*' [-fpermissive]
     const int rc = EVP_PKEY_assign_RSA(key, k);
/opt/openssl-quic/include/openssl/evp.h:418:42: note: in definition of macro 'EVP_PKEY_assign_RSA'
                                         (rsa))
                                          ^~~
/opt/openssl-quic/include/openssl/evp.h:1072:5: note:   initializing argument 3 of 'int EVP_PKEY_assign(EVP_PKEY*, int, void*)'
 int EVP_PKEY_assign(EVP_PKEY *pkey, int type, void *key);
     ^~~~~~~~~~~~~~~

@bryancall bryancall added this to the 10.0.0 milestone Aug 27, 2019
@bryancall bryancall self-assigned this Aug 27, 2019
@bryancall bryancall merged commit 58a1451 into apache:master Aug 28, 2019
@zwoop
Copy link
Contributor

zwoop commented Aug 30, 2019

Cherry-picked to v9.0.x branch.

@zwoop zwoop modified the milestones: 10.0.0, 9.0.0 Aug 30, 2019
@maskit
Copy link
Member

maskit commented Oct 8, 2019

It seems like the same thing happens on PRs for 8.0.x.
Should we backport this to 8.0.x as well?

@randall
Copy link
Contributor

randall commented Oct 21, 2019

8.0.x backport: #6041

@bryancall bryancall modified the milestones: 9.0.0, 8.0.6 Oct 29, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants