Provide stats for the recently introduced HTTP/2 rate limits #5889
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maskit
requested changes
Aug 28, 2019
Member
maskit
left a comment
maskit
left a comment
There was a problem hiding this comment.
Overall looks great to me, but it seems like HTTP2_STAT_INSUFFICIENT_AVG_WINDOW_UPDATE_RATE is not incremented.
jvgutierrez
force-pushed
the
http2-limits-stat
branch
from
82e5768 to
829fd6d
Compare
Member
Author
Fixed! |
maskit
reviewed
Aug 29, 2019
Provide stats for the limits introduced by 9c09dbc
jvgutierrez
force-pushed
the
http2-limits-stat
branch
from
829fd6d to
cc2a918
Compare
maskit
approved these changes
Aug 29, 2019
Contributor
|
Cherry-picked to v9.0.x branch. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Provide stats for the limits introduced by 9c09dbc