Refactor Http1Session to derive from ProxySsn #5988
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A step towards H2-to-Origin. This contains minimal change to compile, and a few TODO comments. This will be followed by many PRs to refactor and cleanup methods and variables. + fix overrides +
maskit
approved these changes
Oct 4, 2019
Member
maskit
left a comment
maskit
left a comment
There was a problem hiding this comment.
Thank you for creating a feature branch. Looks good to me.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up from #5898
Created this feature branch to continue work of H1 outbound refactoring.
This will maintain the same functionality and API and be merged into a 9.1+ release.
A step towards H2-to-Origin.
This contains minimal change to compile, and a few TODO comments. This will be followed by many PRs to refactor and cleanup methods and variables.