Skip to content

cppcheck: Removed problematic move operators for FixedBufferWriter. #6043

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
randall wants to merge 1 commit into from
Closed

cppcheck: Removed problematic move operators for FixedBufferWriter. #6043

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 5 additions & 4 deletions include/tscore/BufferWriter.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -207,6 +207,9 @@ class BufferWriter
};

/** A @c BufferWrite concrete subclass to write to a fixed size buffer.
*
* Copies and moves are forbidden because that leaves the original in a potentially bad state. An
* instance is cheap to construct and should be done explicitly when needed.
*/
class FixedBufferWriter : public BufferWriter
{
Expand All @@ -231,10 +234,8 @@ class FixedBufferWriter : public BufferWriter

FixedBufferWriter(const FixedBufferWriter &) = delete;
FixedBufferWriter &operator=(const FixedBufferWriter &) = delete;
/// Move constructor.
FixedBufferWriter(FixedBufferWriter &&) = default;
/// Move assignment.
FixedBufferWriter &operator=(FixedBufferWriter &&) = default;
FixedBufferWriter(FixedBufferWriter &&) = delete;
FixedBufferWriter &operator=(FixedBufferWriter &&) = delete;

FixedBufferWriter(MemSpan &span) : _buf(span.begin()), _capacity(static_cast<size_t>(span.size())) {}

Expand Down