Skip to content

Make If-Range date compare to be exact match #6089

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
bryancall merged 1 commit into from
Oct 29, 2019
Merged

Make If-Range date compare to be exact match #6089

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions proxy/http/HttpTransactCache.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1381,13 +1381,13 @@ HttpTransactCache::match_response_to_request_conditionals(HTTPHdr *request, HTTP
return HTTP_STATUS_RANGE_NOT_SATISFIABLE;
}
}
// this a Date, similar to If-Unmodified-Since
// this a Date, similar to If-Unmodified-Since but must be an exact match
else {
// lm_value is zero if Last-modified not exists
ink_time_t lm_value = response->get_last_modified();

// condition fails if Last-modified not exists
if ((request->get_if_range_date() < lm_value) || (lm_value == 0)) {
if ((request->get_if_range_date() != lm_value) || (lm_value == 0)) {
return HTTP_STATUS_RANGE_NOT_SATISFIABLE;
} else {
return response->status_get();
Expand Down