Skip to content

Conversation

@masaori335
Copy link
Contributor

@masaori335 masaori335 commented Nov 8, 2019

Checking HAVE_SYS_SYSCTL_H in catch.hpp is introduced by #6145 (3ea8301).
However, it requires including ink_autoconf.h before the check.

+ make test
Making check in src/tscpp/util
/Applications/Xcode.app/Contents/Developer/usr/bin/make  test_tscpputil
  CXX      unit_tests/test_tscpputil-unit_test_main.o
In file included from ../../../../src/tscpp/util/unit_tests/unit_test_main.cc:25:
/Users/jenkins/workspace/macOS-master/compiler/clang/label/macOS/type/release/src/BUILDS/../tests/include/catch.hpp:7114:33: error: variable has incomplete type 'struct kinfo_proc'
            struct kinfo_proc   info;
                                ^
/Users/jenkins/workspace/macOS-master/compiler/clang/label/macOS/type/release/src/BUILDS/../tests/include/catch.hpp:7114:20: note: forward declaration of 'kinfo_proc'
            struct kinfo_proc   info;
                   ^
/Users/jenkins/workspace/macOS-master/compiler/clang/label/macOS/type/release/src/BUILDS/../tests/include/catch.hpp:7125:22: error: use of undeclared identifier 'CTL_KERN'
            mib[0] = CTL_KERN;
                     ^
/Users/jenkins/workspace/macOS-master/compiler/clang/label/macOS/type/release/src/BUILDS/../tests/include/catch.hpp:7126:22: error: use of undeclared identifier 'KERN_PROC'
            mib[1] = KERN_PROC;
                     ^
/Users/jenkins/workspace/macOS-master/compiler/clang/label/macOS/type/release/src/BUILDS/../tests/include/catch.hpp:7127:22: error: use of undeclared identifier 'KERN_PROC_PID'
            mib[2] = KERN_PROC_PID;
                     ^
/Users/jenkins/workspace/macOS-master/compiler/clang/label/macOS/type/release/src/BUILDS/../tests/include/catch.hpp:7140:45: error: use of undeclared identifier 'P_TRACED'
            return ( (info.kp_proc.p_flag & P_TRACED) != 0 );
                                            ^
5 errors generated.
make[2]: *** [unit_tests/test_tscpputil-unit_test_main.o] Error 1
make[1]: *** [check-am] Error 2
make: *** [check-recursive] Error 1

@masaori335 masaori335 added Build work related to build configuration or environment Tests labels Nov 8, 2019
@masaori335 masaori335 added this to the 10.0.0 milestone Nov 8, 2019
@masaori335 masaori335 self-assigned this Nov 8, 2019
@SolidWallOfCode
Copy link
Member

Is this going to be a problem if we update Catch at some later point?

@zwoop
Copy link
Contributor

zwoop commented Nov 8, 2019

@SolidWallOfCode I think the ship sailed with the previous changes. I guess we have to be cognitive about redoing this anytime we update upstream Catch.hpp.

@zwoop zwoop merged commit 98b0aea into apache:master Nov 8, 2019
@zwoop zwoop modified the milestones: 10.0.0, 9.0.0 Nov 8, 2019
@zwoop
Copy link
Contributor

zwoop commented Nov 8, 2019

Cherry-picked to v9.0.x branch.

@bryancall bryancall modified the milestones: 9.0.0, 8.0.6 Mar 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Build work related to build configuration or environment Tests

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants