Skip to content

QUIC: NetEvent and UnixNetVConnection #6229

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
scw00 wants to merge 12 commits into from
Closed

QUIC: NetEvent and UnixNetVConnection #6229

scw00 wants to merge 12 commits into from

Conversation

@scw00
Copy link
Member

@scw00 scw00 commented Nov 26, 2019

No description provided.

@scw00
Copy link
Member Author

scw00 commented Nov 26, 2019 •
edited
Loading

Introduce new class NetEventHandler to Split NetHandler and UnixNetVConnection.

In current implementation. The NetHandler is bond to UnixNetVConnection. So if someone wants to use NetHandler to implement their own nets events handler (like udp), it should create a class which is derived from UnixNetVConnection that will make the object too large.

So abstract necessary api to hide more detail of implementation.

@scw00 scw00 force-pushed the quic_event_handler branch from e91b260 to 44fdca8 Compare November 26, 2019 07:24
@scw00 scw00 changed the title QUIC: NetEventHandler and UnixNetVConnection QUIC: NetEvent and UnixNetVConnection Nov 26, 2019
@scw00
Copy link
Member Author

scw00 commented Dec 3, 2019

[skip ci]

@scw00 scw00 force-pushed the quic_event_handler branch 4 times, most recently from d8a01dc to 18fd6ca Compare December 4, 2019 01:44
@scw00 scw00 force-pushed the quic_event_handler branch 4 times, most recently from ee6f66f to 1cce4d4 Compare December 4, 2019 02:56
@scw00 scw00 force-pushed the quic_event_handler branch 2 times, most recently from bb432a4 to 18e09bf Compare December 5, 2019 10:49
@scw00
Copy link
Member Author

scw00 commented Dec 6, 2019

[approve ci autest]

@scw00 scw00 force-pushed the quic_event_handler branch from f476877 to 116c48a Compare December 16, 2019 02:14
@scw00
Copy link
Member Author

scw00 commented Dec 16, 2019 •
edited
Loading

image

When udp packet coming, AccpetUDP2Connection will create a new UDP2Connection with new fd to accept matched five tuple UDPPacket. And Then later UDPPacket with matched five tuple will be accepted by the new established UDP2Connection.

If no matched connection. AccpetUDP2Connection should callback to QUICPacketHandler to find matched QUICNetVConnection and then QUICPacketHandler dispatch this packet to QUICNetVConnection.

@scw00 scw00 force-pushed the quic_event_handler branch 6 times, most recently from b052eee to be044a0 Compare December 17, 2019 02:06
@scw00 scw00 force-pushed the quic_event_handler branch from be044a0 to 4a5094e Compare December 17, 2019 02:19
oknet
oknet reviewed Dec 17, 2019
View reviewed changes
iocore/net/NetEvent.h Outdated
NetState read{};
NetState write{};

bool closed = false;
Copy link
Member

@oknet oknet Dec 17, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

int closed = 0 ?

Copy link
Member Author

@scw00 scw00 Dec 17, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed

@scw00 scw00 mentioned this pull request Dec 23, 2019
Merged
@scw00
Copy link
Member Author

scw00 commented Jan 9, 2020

close it and open a new pr #6316

@scw00 scw00 closed this Jan 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@oknet oknet oknet left review comments

Assignees

@scw00 scw00

Labels

Network QUIC

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@scw00 @oknet