Skip to content

LGTM: fix a comparison that is always false. #6270

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jrushford merged 1 commit into from
Dec 18, 2019
Merged

LGTM: fix a comparison that is always false. #6270

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 0 additions & 3 deletions proxy/http/remap/NextHopSelectionStrategy.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -267,7 +267,6 @@ NextHopSelectionStrategy::markNextHopDown(const uint64_t sm_id, ParentResult &re
void
NextHopSelectionStrategy::markNextHopUp(const uint64_t sm_id, ParentResult &result)
{
uint32_t old_count = 0;
// Make sure that we are being called back with with a
// result structure with a parent that is being retried
ink_assert(result.retry == true);
Expand All @@ -286,8 +285,6 @@ NextHopSelectionStrategy::markNextHopUp(const uint64_t sm_id, ParentResult &resu

if (!h->available) {
h->set_available();
}
if (h->available && old_count > 0) {
NH_Note("[%" PRIu64 "] http parent proxy %s:%d restored", sm_id, h->hostname.c_str(), h->getPort(scheme));
}
}
Expand Down