XDebug: Always append to the X- header, rather than prepend #6333
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mlibbey
previously requested changes
Feb 23, 2020
Contributor
mlibbey
left a comment
mlibbey
left a comment
There was a problem hiding this comment.
Think we need
- modify docs too (doc/admin-guide/plugins/xdebug.en.rst) to note the change in behavior.
- add this to the release notes/ what's changed.
bryancall
previously approved these changes
Mar 10, 2020
Contributor
Author
|
@mlibbey Yep, I will update the docs, and this will definitely need to go into the Upgrade To release notes. The 9.0.x as so far behind on everything, once the dust settles, my plan is to go through every PR for 9.0.x, and update the release notes properly. I've already marked this one as "incompatible", and I'm hoping others do that as well. That label is a really useful tool for the RM, to know about an incompatible change going into a release. |
zwoop
force-pushed
the
XDebugOrdering
branch
2 times, most recently
from
a11a72c to
d9339c0
Compare
zwoop
added
the
OnDocs
bryancall
approved these changes
Mar 11, 2020
bryancall
dismissed
mlibbey’s stale review
He added docs and will update release notes
zwoop
removed
the
OnDocs
Contributor
Author
|
Cherry-picked to v9.0.x branch. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #6332, and Miles' proposal to change our behavior.