Skip to content

Add virtual destructors for Http2TxFrame, Http2FrequencyCounter #6348

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
SolidWallOfCode merged 1 commit into from
Jan 27, 2020
Merged

Add virtual destructors for Http2TxFrame, Http2FrequencyCounter #6348

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions proxy/http2/Http2Frame.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,6 +53,7 @@ class Http2TxFrame
{
public:
Http2TxFrame(const Http2FrameHeader &h) : _hdr(h) {}
virtual ~Http2TxFrame() {}

// Don't allocate on heap
void *operator new(std::size_t) = delete;
Expand Down
1 change: 1 addition & 0 deletions proxy/http2/Http2FrequencyCounter.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,6 +31,7 @@ class Http2FrequencyCounter
public:
void increment(uint16_t amount = 1);
uint32_t get_count();
virtual ~Http2FrequencyCounter() {}

protected:
uint16_t _count[2] = {0};
Expand Down