-
Notifications
You must be signed in to change notification settings - Fork 844
Replace python with python3 in AuTest #6388
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Ran below command ``` find . -name "*.py" | xargs sed -i '' s/"python "/"python3 "/g ```
|
Maybe we should add this to the beginning of autest.sh? |
|
@ywkaras IIUC, |
|
I'm going to change to use |
|
What I'm suggesting is different, that the Au test framework require that the python command run python version 3.x. |
calavera
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like consistency. I think @ywkaras suggestion can be added in another PR, but this looks necessary anyways.
|
Cherry-picked to v9.0.x branch. |
|
Fwiw, I think a better approach would be to 1) enforce python3 by autest (as suggested above) and 2) make sure that any subsequent invocations of python to exec() the same python, which then properly enforces the same python version. |
Fix #6386
Ran below command