9x lgtm rollup #6429
Merged
9x lgtm rollup #6429
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Addresses issue apache#6350 (cherry picked from commit bea9d08)
* Removing always true/false comparisons. To me these are the ones that made the most sense to remove. There are some others reported that are: 1) Seem to be false positives due to enum usages for some reason 2) Seemed to me that they should be left in for readability purposes. These ones were constant comparisons but when viewed in the code they were in it made sense to leave them because it fit the code scheme and helped readability Addresses issue apache#6354 (cherry picked from commit 6d64842)
…cal storage (apache#6362) (cherry picked from commit 12c967f)
Header guard for EnumDescriptor.h (cherry picked from commit 0e64d36)
This was referenced Feb 18, 2020
Contributor
|
@ezelkow1 do we want this for 9.0 or 9.1 ? |
Member
Author
|
@zwoop up to you, I think initially you had mentioned wanting this in 9.1, but wasnt sure if that was just a typo. They should be good for 9.0 as well |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cherry-pick of PRs:
#6373
#6371
#6363
#6362
#6358