Skip to content

traffic_dump: Make the client-request node gathered in a global hook #6500

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
zwoop merged 1 commit into from
Mar 11, 2020
Merged

traffic_dump: Make the client-request node gathered in a global hook #6500

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 17 additions & 4 deletions plugins/experimental/traffic_dump/traffic_dump.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -297,9 +297,9 @@ write_message_node_no_content(TSMBuffer &buffer, TSMLoc &hdr_loc)
TSMLoc field_loc = TSMimeHdrFieldGet(buffer, hdr_loc, 0);
while (field_loc) {
TSMLoc next_field_loc;
const char *name;
const char *value;
int name_len, value_len;
const char *name = nullptr;
const char *value = nullptr;
int name_len = 0, value_len = 0;
// Append to "fields" list if valid value exists
if ((name = TSMimeHdrFieldNameGet(buffer, hdr_loc, field_loc, &name_len)) && name_len) {
value = TSMimeHdrFieldValueStringGet(buffer, hdr_loc, field_loc, -1, &value_len);
Expand Down Expand Up @@ -415,6 +415,11 @@ session_txn_handler(TSCont contp, TSEvent event, void *edata)
}

case TS_EVENT_HTTP_READ_REQUEST_HDR: {
// This hook is registered globally, not at TS_EVENT_HTTP_SSN_START in
// global_ssn_handler(). As such, this handler will be called with every
// transaction. However, we know that we are dumping this transaction
// because there is a ssnData associated with it.

// We must grab the client request information before remap happens because
// the remap process modifies the request buffer.
TSMBuffer buffer;
Expand All @@ -437,6 +442,8 @@ session_txn_handler(TSCont contp, TSEvent event, void *edata)
TSMLoc hdr_loc;
if (TS_SUCCESS == TSHttpTxnClientReqGet(txnp, &buffer, &hdr_loc)) {
txn_info += write_content_node(TSHttpTxnClientReqBodyBytesGet(txnp)) + "}";
TSHandleMLocRelease(buffer, TS_NULL_MLOC, hdr_loc);
buffer = nullptr;
}
if (TS_SUCCESS == TSHttpTxnServerReqGet(txnp, &buffer, &hdr_loc)) {
TSDebug(PLUGIN_NAME, "Found proxy request");
Expand Down Expand Up @@ -585,7 +592,6 @@ global_ssn_handler(TSCont contp, TSEvent event, void *edata)
TSMutexUnlock(ssnData->disk_io_mutex);

TSHttpSsnHookAdd(ssnp, TS_HTTP_TXN_START_HOOK, ssnData->txn_cont);
TSHttpSsnHookAdd(ssnp, TS_HTTP_READ_REQUEST_HDR_HOOK, ssnData->txn_cont);
TSHttpSsnHookAdd(ssnp, TS_HTTP_TXN_CLOSE_HOOK, ssnData->txn_cont);
break;
}
Expand Down Expand Up @@ -673,6 +679,13 @@ TSPluginInit(int argc, const char *argv[])
TSCont ssncont = TSContCreate(global_ssn_handler, nullptr);
TSHttpHookAdd(TS_HTTP_SSN_START_HOOK, ssncont);
TSHttpHookAdd(TS_HTTP_SSN_CLOSE_HOOK, ssncont);

// Register the collecting of client-request headers at the global level so
// we can process requests before other plugins. (Global hooks are
// processed before session and transaction ones.)
TSCont txn_cont = TSContCreate(session_txn_handler, nullptr);
TSHttpHookAdd(TS_HTTP_READ_REQUEST_HDR_HOOK, txn_cont);

TSLifecycleHookAdd(TS_LIFECYCLE_MSG_HOOK, ssncont);
TSDebug(PLUGIN_NAME, "Initialized with sample pool size %" PRId64 " bytes and disk limit %" PRId64 " bytes",
sample_pool_size.load(), max_disk_usage.load());
Expand Down