Skip to content

Remove method that does nothing. #6501

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
zwoop merged 1 commit into from
Mar 11, 2020
Merged

Remove method that does nothing. #6501

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 0 additions & 8 deletions include/tscpp/api/Url.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -124,14 +124,6 @@ class Url : noncopyable
*/
void setPort(const uint16_t);

/**
* This method allows you to reset the url, this will force the Url to fully re-read all cached values.
* If this method is used on a Detached Requests' Url object it will completely destroy the values.
*
* \note This method should rarely be used.
*/
void reset();

private:
bool isInitialized() const;
void init(void *hdr_buf, void *url_loc);
Expand Down
5 changes: 0 additions & 5 deletions src/tscpp/api/Url.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -63,11 +63,6 @@ bool inline Url::isInitialized() const
return state_->hdr_buf_ && state_->url_loc_;
}

void
Url::reset()
{
}

std::string
Url::getUrlString() const
{
Expand Down
1 change: 0 additions & 1 deletion src/tscpp/api/utils_internal.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,7 +61,6 @@ handleTransactionEvents(TSCont cont, TSEvent event, void *edata)
utils::internal::setTransactionEvent(transaction, event);
switch (event) {
case TS_EVENT_HTTP_POST_REMAP:
transaction.getClientRequest().getUrl().reset();
// This is here to force a refresh of the cached client request url
TSMBuffer hdr_buf;
TSMLoc hdr_loc;
Expand Down