TS-4472: Decrement http_current_active_client_connections_stat in HTTP/2 #660
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`http_current_active_client_connections_stat` is incremented in HttpSM. And if client connection is HTTP/1.1, this is decremented in Http1ClientTransaction. But if client connection is HTTP/2, this is not decremented anywhere.
Contributor
|
👍 - looks good |
shinrich
added a commit
to shinrich/trafficserver
that referenced
this pull request
Jan 9, 2018
JosiahWI
pushed a commit
to JosiahWI/trafficserver
that referenced
this pull request
Jul 19, 2023
* Require use of 'override' keyword when valid. (apache#8737) Co-authored-by: Walt Karas <wkaras@yahooinc.com> (cherry picked from commit 97ee33c) * Use override keyword in RPC code.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
http_current_active_client_connections_statis incremented in HttpSM.And if client connection is HTTP/1.1, this is decremented in Http1ClientTransaction.
But if client connection is HTTP/2, this is not decremented anywhere.