Fix use-after free #6709
Closed
Fix use-after free #6709
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
[approve ci autest] |
Member
Author
|
I'm reconsidering the original fix to #6469. Will do some more experiments locally. |
Member
Author
|
Seems likely that this is the same as PR #6574 |
a-canary
reviewed
Apr 29, 2020
Collaborator
a-canary
left a comment
a-canary
left a comment
There was a problem hiding this comment.
why wouldn't the session's do_io_close also close the vc? ... and do it in the correct order.
Member
Author
|
There are better ways to do this. Will put up new PR soon. |
Contributor
|
Please remember to remove Milestone and Projects from PRs that are closed without merging. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@bneradt found this use-after free when running prod sim.
The problem was introduced with #6469
The do_io_close may close the session object.