ip_resolve - Make config variable overridable #6769
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brbzull0
force-pushed
the
dmeden/make_ip-resolve-overridable
branch
from
eabea01 to
be21982
Compare
| .. c:macro:: TS_CONFIG_SSL_CLIENT_SNI_POLICY | ||
| .. c:macro:: TS_CONFIG_SSL_CLIENT_PRIVATE_KEY_FILENAME | ||
| .. c:macro:: TS_CONFIG_SSL_CLIENT_CA_CERT_FILENAME | ||
| .. c:macro:: TS_CONFIG_HTTP_HOST_RESOLUTION_STYLE |
Member
There was a problem hiding this comment.
You said you'd changed this.
Contributor
Author
There was a problem hiding this comment.
my bad! though it's updated in the code, I didn't update the doc properly.
SolidWallOfCode
suggested changes
May 19, 2020
Member
SolidWallOfCode
left a comment
SolidWallOfCode
left a comment
There was a problem hiding this comment.
Change the "STYLE" to "PREFERENCE".
brbzull0
force-pushed
the
dmeden/make_ip-resolve-overridable
branch
from
be21982 to
bedabb5
Compare
brbzull0
force-pushed
the
dmeden/make_ip-resolve-overridable
branch
from
bedabb5 to
33f0674
Compare
Contributor
Author
|
[approve ci autest] |
SolidWallOfCode
approved these changes
May 20, 2020
Contributor
Author
|
[approve ci autest] |
1 similar comment
Contributor
Author
|
[approve ci autest] |
SolidWallOfCode
approved these changes
May 20, 2020
Contributor
|
Cherry-picked to v9.0.x branch. |
This was referenced May 16, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With this change, host resolution order can now be override per transaction if needed. Documentation was also updated to reflect this change.
Test also included.