Skip to content

1. Set a non-zero default value for TLS Client Handshake Timeout #6781

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sudheerv merged 2 commits into from
May 14, 2020
Merged

1. Set a non-zero default value for TLS Client Handshake Timeout #6781

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d901149
1. Set a non-zero default value for TLS Client Handshake Timeout
sudheerv May 14, 2020
c900134
Bump the timeout to 30 sec to account for multiple RTT (thanks Bryan)
sudheerv May 14, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions doc/admin-guide/files/records.config.en.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1246,8 +1246,8 @@ HTTP Connection Timeouts
:overridable:

Specifies how long |TS| keeps connections to clients open for a
subsequent request after a transaction ends. A value of ``0`` will disable
the no activity timeout.
subsequent request after a transaction ends. A value of ``0`` will set
`proxy.config.net.default_inactivity_timeout` as the timeout.

See :ref:`admin-performance-timeouts` for more discussion on |TS| timeouts.

Expand All @@ -1256,8 +1256,8 @@ HTTP Connection Timeouts
:overridable:

Specifies how long |TS| keeps connections to origin servers open
for a subsequent transfer of data after a transaction ends. A value of
``0`` will disable the no activity timeout.
for a subsequent transfer of data after a transaction ends. A value of ``0`` will
set `proxy.config.net.default_inactivity_timeout` as the timeout.

See :ref:`admin-performance-timeouts` for more discussion on |TS| timeouts.

Expand Down
2 changes: 1 addition & 1 deletion mgmt/RecordsConfig.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1150,7 +1150,7 @@ static const RecordElement RecordsConfig[] =
,
{RECT_CONFIG, "proxy.config.ssl.server.dhparams_file", RECD_STRING, nullptr, RECU_RESTART_TS, RR_NULL, RECC_NULL, nullptr, RECA_NULL}
,
{RECT_CONFIG, "proxy.config.ssl.handshake_timeout_in", RECD_INT, "0", RECU_RESTART_TS, RR_NULL, RECC_INT, "[0-65535]", RECA_NULL}
{RECT_CONFIG, "proxy.config.ssl.handshake_timeout_in", RECD_INT, "30", RECU_RESTART_TS, RR_NULL, RECC_INT, "[0-65535]", RECA_NULL}
,
{RECT_CONFIG, "proxy.config.ssl.cert.load_elevated", RECD_INT, "0", RECU_RESTART_TS, RR_NULL, RECC_INT, "[0-1]", RECA_READ_ONLY}
,
Expand Down