Fix timeout test #6871
Closed
Fix timeout test #6871
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shinrich
force-pushed
the
fix-timeout-test
branch
2 times, most recently
from
f5b7f65 to
a89b1fc
Compare
Member
|
[approve ci autest] Rerunning autest because actual tests were skipped. |
Member
Author
|
[approve ci autest] |
Member
Author
|
Closed in preference to PR #6897 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was some concern that the fixes to proxy.config.http.connect_attempts_timeout made in 2018 that enabled this timeout to track the connect timeout rather than time to first byte (TTFB) weren't really working.
The previous test wasn't accurately exercising the SYN timeout. To do that, you need privilege to block the SYN-ACK. This test uses network namespace and virtual connections to set up a place to attach iptable filter rules to drop the SYN and exercise the SYN timeout case.
The test is turned off by default since we cannot assume privilege when running within CI. But you should be able to enable and run this in your linux environment (providing ip netns).